[Mlir-commits] [mlir] [mlir][memref] Add a new `ReifyResultShapes` pass (PR #145927)

[Nicolas Vasilache]

nicolasvasilache wrote:

> If you want me to stamp this as a WIP/to-be-evolved thing, thats fine, but it is relying on what I see as an inverted dependence structure between the op and the interface method. I would have raised this on the implementation of the `reifyResultShape` to begin with if it hadnt sent/reviewed/landed before anyone from a different time zone had any chance to review it.

Hmmm I didn't get that, what is wrong in the `reifyResultShape` implementation?

I can see there is no guaranteed confluence between `ReifyRankedShapedTypeOpInterface` and op verifiers (at least for ops that aren't `IndexingOpInterface`). I can implement in terms of `IndexingOpInterface` and have op SoT + `reifyResultShape` just use that impl. (or even be generated).

I am happy to do that now for PadOp if there is a preference for it.

https://github.com/llvm/llvm-project/pull/145927