[Mlir-commits] [mlir] [mlir][Vector] Add `vector.shuffle` tree transformation (PR #145740)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Thanks - this is quite involved, but you've done a great job documenting and modularising it!

The high-level logic makes sense, but some of the finer details are still unclear to me. I’ll definitely need a few more passes through it 😅

As usual, I started with the tests to get a broad overview. I’ve left a few comments there - mostly suggesting more emphasis on edge cases. Maybe you could consider grouping the tests to make those clearer?

Also, replacing some (or most) uses of failure with notifyMatchFailure would be great 🙂 #selfDocumentingCode

https://github.com/llvm/llvm-project/pull/145740