[Mlir-commits] [mlir] [mlir][linalg] Allow promotion to use the original subview size (PR #144334)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Sun Jun 29 00:13:58 PDT 2025
================
@@ -811,6 +819,7 @@ struct PromotionInfo {
};
FailureOr<PromotionInfo>
promoteSubviewAsNewBuffer(OpBuilder &b, Location loc, memref::SubViewOp subView,
+ bool useOriginalSubviewSize,
----------------
zbenzion wrote:
Since this method is used both internally in Promotion.cpp (`LinalgOpInstancePromotionOptions`) and is exposed externally (`LinalgPromotionOptions`) I feel like it'd be a little unnatural to use one or the other at this stage. I kept the single argument, as you suggested.
If everything looks good, I'd appreciate if you can hit the merge button for me, since I don't have write access.
Thanks for the review!
https://github.com/llvm/llvm-project/pull/144334
More information about the Mlir-commits
mailing list