[Mlir-commits] [mlir] Fix bug in `visitDivExpr`, `visitModExpr` and `visitMulExpr` (PR #145290)

Uday Bondhugula llvmlistbot at llvm.org
Fri Jun 27 04:38:41 PDT 2025


================
@@ -418,6 +418,14 @@ class SimpleAffineExprFlattener
                                              AffineExpr localExpr);
 
 private:
+  /// Flatten binary expression `expr` and add it to `result`. If `expr` is a
+  /// dimension, symbol or constant, we add it to appropriate index in `result`.
+  /// Otherwise we add it in the local variable section. `lhs` and `rhs` are the
----------------
bondhugula wrote:

It's unclear here what operands of `expr` are! An AffineExpr doesn't have any operands. Rephrase.

https://github.com/llvm/llvm-project/pull/145290


More information about the Mlir-commits mailing list