[Mlir-commits] [mlir] [mlir][vector] Add build method for vector.to_elements (PR #145114)

[Andrzej Warzyński]

banach-space wrote:

Folks, I'm not comfortable accepting this PR in its current state.

> I can wait until this PR can be stacked with something that can use it, if that's preferred

This would be my preference.

While I have nothing against the change in principle, without tests or any upstream usage, it currently looks like "dead code." That means it's vulnerable to being removed later on, and it's hard to justify exceptions - how would we distinguish it from other unused code upstream?

>  In the meantime, we can use this build for downstream integration and experimentation

My main concern is the precedent this sets. Landing code without tests or usage, even with good intentions, weakens our standards and makes future exceptions harder to argue against. It's important we maintain a consistent bar for what's accepted upstream.

That said, I'm not blocking the PR - just expressing a strong preference to hold off until this can land alongside its first user.

https://github.com/llvm/llvm-project/pull/145114