[Mlir-commits] [mlir] [mlir][Canonicalize] Copy ParallelOp Attributes in Single-iteration (PR #145852)
Ivan Butygin
llvmlistbot at llvm.org
Thu Jun 26 13:49:53 PDT 2025
================
@@ -3133,6 +3133,16 @@ struct ParallelOpSingleOrZeroIterationDimsFolder
newSteps, op.getInitVals(), nullptr);
// Erase the empty block that was inserted by the builder.
rewriter.eraseBlock(newOp.getBody());
+
+ // The new ParallelOp needs to keep all attributes from the old one, except
+ // for "operandSegmentSizes" which will be outdated.
+ for (const auto &namedAttr : op->getAttrs()) {
+ if (namedAttr.getName() == ParallelOp::getOperandSegmentSizeAttr())
+ continue;
+ rewriter.modifyOpInPlace(newOp, [&]() {
+ newOp->setAttr(namedAttr.getName(), namedAttr.getValue());
+ });
+ }
----------------
Hardcode84 wrote:
Side comment: in _another_ downstream project I used regions to model custom op attributes https://github.com/intel/mlir-extensions/blob/main/docs/rfcs/RegionDialect.md, which is more likely to survive unrelated passes.
https://github.com/llvm/llvm-project/pull/145852
More information about the Mlir-commits
mailing list