[Mlir-commits] [mlir] [mlir][spirv][nfc] Add StorageImageReadWithoutFormat capability to the Target test (PR #145949)

Igor Wodiany llvmlistbot at llvm.org
Thu Jun 26 11:21:48 PDT 2025


https://github.com/IgWod-IMG created https://github.com/llvm/llvm-project/pull/145949

The serialized SPIR-V would not validate as the capability required for Unknown format in the image read was missing. Spotted while reviewing  #145873.

>From 93ac24d1d87f148ae7b5da38286d7f52d9f4aaa8 Mon Sep 17 00:00:00 2001
From: Igor Wodiany <igor.wodiany at imgtec.com>
Date: Thu, 26 Jun 2025 19:15:02 +0100
Subject: [PATCH] [mlir][spirv][nfc] Add StorageImageReadWithoutFormat
 capability to the Target test

The serialized SPIR-V would not validate as the capability required
for Unknown format in the image read was missing.
---
 mlir/test/Target/SPIRV/image-ops.mlir | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/test/Target/SPIRV/image-ops.mlir b/mlir/test/Target/SPIRV/image-ops.mlir
index b8d19f0f9a7d1..1ea66af6404dd 100644
--- a/mlir/test/Target/SPIRV/image-ops.mlir
+++ b/mlir/test/Target/SPIRV/image-ops.mlir
@@ -42,7 +42,7 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, ImageQuery, Link
 
 // -----
 
-spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, StorageImageWriteWithoutFormat, Linkage], []> {
+spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, StorageImageWriteWithoutFormat, StorageImageReadWithoutFormat, Linkage], []> {
   spirv.func @image_read_write(%arg0 : !spirv.image<f32, Dim2D, NoDepth, NonArrayed, SingleSampled, NoSampler, Unknown>, %arg1 : vector<2xsi32>) "None" {
     // CHECK: spirv.ImageRead {{%.*}}, {{%.*}} : !spirv.image<f32, Dim2D, NoDepth, NonArrayed, SingleSampled, NoSampler, Unknown>, vector<2xsi32> -> vector<4xf32>
     %0 = spirv.ImageRead %arg0, %arg1 : !spirv.image<f32, Dim2D, NoDepth, NonArrayed, SingleSampled, NoSampler, Unknown>, vector<2xsi32> -> vector<4xf32>



More information about the Mlir-commits mailing list