[Mlir-commits] [mlir] [mlir] Remove extra whitespace during printout in prop-dict (#145695) (PR #145908)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Jun 26 10:20:19 PDT 2025
weirdsmiley wrote:
@joker-eph yes there are cases like [this](https://github.com/llvm/llvm-project/blob/066a14d4d483969ee3724995319cf225ac4010b1/mlir/test/Target/LLVMIR/Import/ident.ll#L3), outside of `<>` where removing whitespace would lead to something like the following.
expected:
`; CHECK: module attributes {`
if whitespace removed:
`; CHECK: module attributes{`
There are more test cases like this (and probably others, total failed cases are 367). I got this from failed test cases (`ninja check-mlir`) after apply my patch.
I think that adding a whitespace in all cases would be consistent and will have a straightforward fix.
https://github.com/llvm/llvm-project/pull/145908
More information about the Mlir-commits
mailing list