[Mlir-commits] [mlir] [mlir][spirv]: Add `OpImageFetch` (PR #145873)

[Igor Wodiany]

================
@@ -51,3 +51,13 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, StorageImageWrit
     spirv.Return
   }
 }
+
+// -----
+
+spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, StorageImageWriteWithoutFormat, Linkage], []> {
+  spirv.func @image_fetch(%arg0 : !spirv.image<f32, Dim2D, NoDepth, NonArrayed, SingleSampled, NeedSampler, Unknown>, %arg1 : vector<2xsi32>) "None" {
----------------
IgWod-IMG wrote:

Could you please move this function into the first module in the file alongside all tested ops, unless there is a good reason for having it separate. Just make sure the format is not Unknown. The module you copied is specifically for testing the case where StorageImageWriteWithoutFormat is set for `spirv.ImageWrite`:

> The [Image Format](https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#Image_Format) must not be Unknown, unless the StorageImageWriteWithoutFormat [Capability](https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#Capability) was declared.

https://github.com/llvm/llvm-project/pull/145873