[Mlir-commits] [mlir] [mlir][Canonicalize] Copy ParallelOp Attributes in Single-iteration (PR #145852)
Mehdi Amini
llvmlistbot at llvm.org
Thu Jun 26 01:14:45 PDT 2025
================
@@ -3133,6 +3133,16 @@ struct ParallelOpSingleOrZeroIterationDimsFolder
newSteps, op.getInitVals(), nullptr);
// Erase the empty block that was inserted by the builder.
rewriter.eraseBlock(newOp.getBody());
+
+ // The new ParallelOp needs to keep all attributes from the old one, except
+ // for "operandSegmentSizes" which will be outdated.
+ for (const auto &namedAttr : op->getAttrs()) {
+ if (namedAttr.getName() == ParallelOp::getOperandSegmentSizeAttr())
+ continue;
+ rewriter.modifyOpInPlace(newOp, [&]() {
+ newOp->setAttr(namedAttr.getName(), namedAttr.getValue());
+ });
+ }
----------------
joker-eph wrote:
1) This looks costly to me to do this one attribute at a time. It'll incur a lot of round-trip to the uniquer
2) These a discardable attributes, we can't propagate them blindly through transformations: this is unsafe.
https://github.com/llvm/llvm-project/pull/145852
More information about the Mlir-commits
mailing list