[Mlir-commits] [mlir] [mlir][tosa] Change the shift of mul to be required (PR #125297)

[Matthias Gehre]

================
@@ -812,7 +812,8 @@ def Tosa_MulOp : Tosa_Op<"mul", [
   let arguments = (ins
     Tosa_Tensor:$input1,
     Tosa_Tensor:$input2,
-    Optional<TosaTensorRankOf<[Tosa_Int8], [1]>>:$shift
+    // Apply right shift on i32_t input data only
+    Tosa_ScalarInt8Tensor:$shift
----------------
mgehre-amd wrote:

I would also like to know the answer to this question. Changes like this cause quite some churn downstream, so it would be nice to see some rational.

https://github.com/llvm/llvm-project/pull/125297