[Mlir-commits] [mlir] [mlir][linalg] Fix module dependency issue due to unused import (PR #145727)

Spenser Bauman llvmlistbot at llvm.org
Wed Jun 25 08:50:28 PDT 2025


https://github.com/sabauma created https://github.com/llvm/llvm-project/pull/145727

This include introduces a dependency for LinalgTransforms on LinalgTransformOps, which is unspecified in the module dependencies, and would produce a cyclic dependency if it were specified.

The include is unused in WinogradConv2D.cpp, so this change removes it.

>From 86f2bcd69f8bb771fd350c660e50a20fa3c2a47b Mon Sep 17 00:00:00 2001
From: Spenser Bauman <sabauma at fastmail>
Date: Wed, 25 Jun 2025 11:45:50 -0400
Subject: [PATCH] [mlir][linalg] Fix module dependency issue due to unused
 import

This include introduces a dependency for LinalgTransforms on
LinalgTransformOps, which is unspecified in the module dependencies, and
would produce a cyclic dependency if it were specified.

The include is unused in WinogradConv2D.cpp, so this change removes it.
---
 mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp b/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp
index c61b23c63dc56..4e90defebcf5c 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp
@@ -15,7 +15,6 @@
 #include "mlir/Dialect/Affine/IR/AffineOps.h"
 #include "mlir/Dialect/Arith/IR/Arith.h"
 #include "mlir/Dialect/Linalg/IR/Linalg.h"
-#include "mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.h"
 #include "mlir/Dialect/Linalg/Utils/Utils.h"
 #include "mlir/Dialect/Tensor/IR/Tensor.h"
 #include "mlir/Dialect/Utils/StaticValueUtils.h"



More information about the Mlir-commits mailing list