[Mlir-commits] [mlir] [mlir][memref]: Fix Bug in GlobalOp Verifier (PR #144900)

[Andrzej Warzyński]

banach-space wrote:

@FranklandJack , I noticed that you forced-pushed and erased the history. Please try to avoid that:
* https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes

In particular, some earlier comments refer to the original revision, but that context is gone making it hard for folks referring to this in the future to follow the discussion. 

Not a big deal, it is hard to keep track of all the LLVM policies/guidelines. And, TBH, many people do force-push (e.g. to rebase on top of main), but even then we should preserve the original commits.

Most importantly, thanks for fixing this!

https://github.com/llvm/llvm-project/pull/144900