[Mlir-commits] [mlir] [mlir][NFC] Move LLVM::ModuleTranslation::SaveStack to a shared header (PR #144897)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Tue Jun 24 23:34:53 PDT 2025


ftynse wrote:

@tblah this PR had a layering violation that I overlooked: files in lib/Support must not depend on mlir/IR. It was "fixed" by https://github.com/llvm/llvm-project/pull/145598 instead of reverting... I think a cleaner fix would have been to move `WalkResult` to lib/Support because neither it nor the stack logic depends on IR constructs.

https://github.com/llvm/llvm-project/pull/144897


More information about the Mlir-commits mailing list