[Mlir-commits] [mlir] [mlir] Return vectorized values instead of replacing (PR #144158)

[Andrzej Warzyński]

================
@@ -771,17 +771,24 @@ LogicalResult deallocateGPUPrivateMemory(OpBuilder &, Value /*buffer*/);
 /// to work (these are checked by the vectorizer itself).
 bool hasVectorizationImpl(Operation *);
 
+/// Transformation information returned after vectorizing.
+struct VectorizationResult {
+  /// Results of the vectorization transform to replace the original operation.
+  SmallVector<Value> replacements;
+};
----------------
banach-space wrote:

These are great points - thanks!

Let’s park the bikeshedding here (which I kicked off 😅). What you’re proposing makes sense to me!

https://github.com/llvm/llvm-project/pull/144158