[Mlir-commits] [mlir] [mlir][linalg] Allow promotion to use the original subview size (PR #144334)

[llvmlistbot at llvm.org]

================
@@ -811,6 +819,7 @@ struct PromotionInfo {
 };
 FailureOr<PromotionInfo>
 promoteSubviewAsNewBuffer(OpBuilder &b, Location loc, memref::SubViewOp subView,
+                          bool useOriginalSubviewSize,
----------------
zbenzion wrote:

In general, sounds good!

It seems though that the caller `promoteSubViews` is already using `LinalgOpInstancePromotionOptions`, which is an internal representation in Promotion.cpp. 
Another issue is that `LinalgPromotionOptions` doesn't force an explicit `allocationFn`, and `promoteSubviewAsNewBuffer` does.

We could maybe, alternatively, provide a `LinalgPromoteSubviewAsNewBufferOptions`, which will pack the boolean and the allocation function.
What do you think?

https://github.com/llvm/llvm-project/pull/144334