https://github.com/ftynse commented: Okay for me in principle. Please address the comments. Also please document steps that are needed to add support for other Winograd shapes. https://github.com/llvm/llvm-project/pull/144657