[Mlir-commits] [mlir] [mlir][TilingInterface] NFC Improve comment for `tiledAndFusedOps` member of `SCFTileAndFuseResult` (PR #145397)

Aaron St George llvmlistbot at llvm.org
Mon Jun 23 12:53:37 PDT 2025


https://github.com/AaronStGeorge created https://github.com/llvm/llvm-project/pull/145397

Comment was a little unclear, hopefully this change is an improvement.

>From cbd7e3a9c5b02b203868265f0d9456a45e0fb4ce Mon Sep 17 00:00:00 2001
From: AaronStGeorge <aaronstgeorge at gmail.com>
Date: Mon, 23 Jun 2025 19:50:12 +0000
Subject: [PATCH] [mlir][TilingInterface] NFC Improve comment for
 tiledAndFusedOps member of SCFTileAndFuseResult

Comment was a little unclear, hopefully this change is an improvement.
---
 .../mlir/Dialect/SCF/Transforms/TileUsingInterface.h       | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h b/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
index 9feb04dbe03c1..7b43aa43c7517 100644
--- a/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
+++ b/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
@@ -272,9 +272,10 @@ FailureOr<SmallVector<Operation *>> yieldReplacementForFusedProducer(
 struct SCFTileAndFuseResult {
   /// List of untiled operations that were fused with the tiled consumer.
   llvm::SetVector<Operation *> fusedProducers;
-  /// List of tiled and fused operations generated. The first one in this list
-  /// is guaranteed to be the tiled operations generated during tiling of the
-  /// generated operation.
+  /// List of tiled and fused operations generated. The first element is always
+  /// the tiled version of the original consumer operation processed by
+  /// `tileConsumerAndFuseProducersUsingSCF`, followed by any operations that
+  /// were fused with it.
   llvm::SetVector<Operation *> tiledAndFusedOps;
   /// The `scf.for` operations that iterate over the tiles.
   SmallVector<LoopLikeOpInterface> loops;



More information about the Mlir-commits mailing list