[Mlir-commits] [mlir] [MLIR][Linalg] Harden parsing Linalg named ops (PR #145337)

Renato Golin llvmlistbot at llvm.org
Mon Jun 23 11:58:54 PDT 2025


================
@@ -500,8 +531,13 @@ class RegionBuilderHelper {
         return builder.create<complex::SubOp>(arg0.getLoc(), arg0, arg1);
       if (allFloatingPoint)
         return builder.create<arith::SubFOp>(arg0.getLoc(), arg0, arg1);
-      if (allBool)
+      if (allBool) {
+        if (emitError) {
----------------
rengolin wrote:

What about something like:
```c++
// Mostly helpful to the constant message ones
Value returnError(StringRef& msg) {
  emitError() << msg;
  return nullptr;
}
```

then use:
```c++
if (emitError)
  return returnError("message here");
llvm_unreachable("message here");
```

https://github.com/llvm/llvm-project/pull/145337


More information about the Mlir-commits mailing list