[Mlir-commits] [mlir] [mlir][vector] NFC - Add more structured interface support to vector.contract (PR #145313)

[Renato Golin]

================
@@ -207,6 +207,39 @@ def Vector_ContractionOp :
               .template getAsValueRange<IteratorTypeAttr, IteratorType>();
       return {range.begin(), range.end()};
     }
+
+    //===------------------------------------------------------------------===//
+    // The code below is shared with LinalgStructuredInterface.
+    // vector.contract is really a linalg.generic on vectors without region.
----------------
rengolin wrote:

Good point. We shouldn't design the `vector` interfaces _as if_ they only come from a `linalg` point of view.

PS: I don't think this was the intention, but leaving a comment like that could make people believe it was.

https://github.com/llvm/llvm-project/pull/145313