[Mlir-commits] [mlir] [mlir][vector] NFC - Add more structured interface support to vector.contract (PR #145313)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Jun 23 06:37:18 PDT 2025


================
@@ -207,6 +207,39 @@ def Vector_ContractionOp :
               .template getAsValueRange<IteratorTypeAttr, IteratorType>();
       return {range.begin(), range.end()};
     }
+
+    //===------------------------------------------------------------------===//
+    // The code below is shared with LinalgStructuredInterface.
+    // vector.contract is really a linalg.generic on vectors without region.
----------------
banach-space wrote:

If this is shared, let's try to identify a better location for it outside of the Vector dialect.

Also, could we avoid referring specifically to `Linalg` in generic `Vector` documentation? It was pointed out to me recently that not all users interact with `Vector` through `Linalg`, so keeping the documentation relevant to a broader audience would be helpful.

https://github.com/llvm/llvm-project/pull/145313


More information about the Mlir-commits mailing list