[Mlir-commits] [mlir] Fix bug in `visitDivExpr` and `visitModExpr` (PR #145290)
Uday Bondhugula
llvmlistbot at llvm.org
Mon Jun 23 02:03:01 PDT 2025
================
@@ -1178,9 +1178,9 @@ static AffineExpr getSemiAffineExprFromFlatForm(ArrayRef<int64_t> flatExprs,
continue;
AffineExpr expr = it.value();
auto binaryExpr = dyn_cast<AffineBinaryOpExpr>(expr);
- if (!binaryExpr)
- continue;
-
+ assert(binaryExpr &&
----------------
bondhugula wrote:
It's not clear why this binary expression is a "local" expression. The variables aren't named well here at the least. `addedToMap` and `binaryExpr` should be named better.
https://github.com/llvm/llvm-project/pull/145290
More information about the Mlir-commits
mailing list