[Mlir-commits] [mlir] [mlir] [docs] Minor documentation fix in `mlir-reduce` docs (PR #142479)
Longsheng Mou
llvmlistbot at llvm.org
Sun Jun 22 23:57:56 PDT 2025
================
@@ -31,7 +31,7 @@ results and different time complexity. You can run as
As mentioned, you need to provide a command to `mlir-reduce` which identifies
cases you're interested in. For each intermediate output generated during
reduction, `mlir-reduce` will run the command over the it, the script should
-returns 1 for interesting case, 0 otherwise. The sample script,
+returns 0 for an interesting case, 1 otherwise. The sample script,
----------------
CoTinker wrote:
```shell
mlir-opt -convert-vector-to-spirv $1 | grep "failed to materialize"
if [[ $? -eq 1 ]]; then
exit 1
```
That means `grep "failed to materialize"` failed and returned 1.
So I think changing it to `script should return 0 for an interesting case, 1 otherwise` is correct, because the interesting case is when `grep` succeeds in finding something.
https://github.com/llvm/llvm-project/pull/142479
More information about the Mlir-commits
mailing list