[Mlir-commits] [mlir] [mlir][linalg] Extend `FuseElementwiseOps` pattern to work with named ops (PR #144922)

[llvmlistbot at llvm.org]

https://github.com/MaheshRavishankar requested changes to this pull request.

I dont have a major issue with the change itself, but I think this is different from the direction I think we had agreed on. I think we need to remove regions from the elementwise/contract/fill ops. If we go down that path then we will really not need anything cause elementwise fusion will require generalization (or at least some interface methods that can give you the region needed.

At the very least I think a lot of complexity introduced here are due to map operations. If we fix that then Id expect almost no changes to the fusion logic here. Id rather do that than import that complexity here.


https://github.com/llvm/llvm-project/pull/144922