[Mlir-commits] [mlir] Make getStridesAndOffset const (PR #145148)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Fri Jun 20 21:31:21 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir
Author: Evan Liu (Evanyl)
<details>
<summary>Changes</summary>
Make getStridesAndOffset const.
---
Full diff: https://github.com/llvm/llvm-project/pull/145148.diff
2 Files Affected:
- (modified) mlir/include/mlir/IR/BuiltinTypes.td (+2-2)
- (modified) mlir/lib/IR/BuiltinTypes.cpp (+3-2)
``````````diff
diff --git a/mlir/include/mlir/IR/BuiltinTypes.td b/mlir/include/mlir/IR/BuiltinTypes.td
index 55d64d663f7ed..89ade79a3ac02 100644
--- a/mlir/include/mlir/IR/BuiltinTypes.td
+++ b/mlir/include/mlir/IR/BuiltinTypes.td
@@ -863,11 +863,11 @@ def Builtin_MemRef : Builtin_Type<"MemRef", "memref", [
/// the distance in the number of elements between successive entries along
/// a particular dimension.
LogicalResult getStridesAndOffset(SmallVectorImpl<int64_t> &strides,
- int64_t &offset);
+ int64_t &offset) const;
/// Wrapper around getStridesAndOffset(SmallVectorImpl<int64_t>, int64_t)
/// that will assert if the logical result is not succeeded.
- std::pair<SmallVector<int64_t>, int64_t> getStridesAndOffset();
+ std::pair<SmallVector<int64_t>, int64_t> getStridesAndOffset() const;
/// Return "true" if the layout is compatible with strided semantics.
bool isStrided();
diff --git a/mlir/lib/IR/BuiltinTypes.cpp b/mlir/lib/IR/BuiltinTypes.cpp
index 97bab479c79bf..e3a00ac5a14b1 100644
--- a/mlir/lib/IR/BuiltinTypes.cpp
+++ b/mlir/lib/IR/BuiltinTypes.cpp
@@ -730,11 +730,12 @@ MemRefType MemRefType::canonicalizeStridedLayout() {
}
LogicalResult MemRefType::getStridesAndOffset(SmallVectorImpl<int64_t> &strides,
- int64_t &offset) {
+ int64_t &offset) const {
return getLayout().getStridesAndOffset(getShape(), strides, offset);
}
-std::pair<SmallVector<int64_t>, int64_t> MemRefType::getStridesAndOffset() {
+std::pair<SmallVector<int64_t>, int64_t>
+MemRefType::getStridesAndOffset() const {
SmallVector<int64_t> strides;
int64_t offset;
LogicalResult status = getStridesAndOffset(strides, offset);
``````````
</details>
https://github.com/llvm/llvm-project/pull/145148
More information about the Mlir-commits
mailing list