[Mlir-commits] [flang] [mlir] [MLIR] Add ComplexTOROCDL pass (PR #144926)

[Akash Banerjee]

TIFitis wrote:

Thanks @ftynse and @krzysz00 for the review, I've addressed the changes requested.

I haven't changed the pass name yet, I'll do so if we decide to keep the pass separate from `MathToROCDL` (does `ComplexToROCDLCalls` sound alright?). On that note, regarding merging this pass to `MathToROCDL` or making use of `mlir/lib/Conversion/GPUCommon/OpToFuncCallLowering.h`, I hit the assert below. I'm not entirely sure why that assert is needed but for now it doesn't seem compatible with the `Complex` op. Let me know what are your thoughts.

Thanks.
https://github.com/llvm/llvm-project/blob/04e2e581ac000934782398e05853338040bf7c46/mlir/lib/Conversion/GPUCommon/OpToFuncCallLowering.h#L80

https://github.com/llvm/llvm-project/pull/144926