[Mlir-commits] [flang] [mlir] [MLIR] Add ComplexTOROCDL pass (PR #144926)

[Akash Banerjee]

TIFitis wrote:

> > I will note that MathToROCDL is already the "patterns for calling functions from the ROCm device libraries" pass, so ComplexToROCDL is at least consistent with existing practice.
> 
> At which point, we could merge this into that and rename it to something more obvious.

Hi @ftynse,
Could you please clarify what you’d like me to do? Are you suggesting that `ComplexToROCDL` be renamed to something like `ComplexToROCDLCall`? Or are you proposing that we merge `ComplexToROCDL` and `MathToROCDL` into a single pass? If the latter, do you have a preferred name in mind for the merged pass?

Thanks!

https://github.com/llvm/llvm-project/pull/144926