[Mlir-commits] [mlir] [mlir][arith][NFC] Remove redundant trait declaration (PR #145007)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Fri Jun 20 02:52:18 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-arith

Author: Matthias Springer (matthias-springer)

<details>
<summary>Changes</summary>

`Arith_Op` already declares the `ElementwiseMappable` traits, so they don't have to be declared for `arith.select`.


---
Full diff: https://github.com/llvm/llvm-project/pull/145007.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/Arith/IR/ArithOps.td (+1-2) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/Arith/IR/ArithOps.td b/mlir/include/mlir/Dialect/Arith/IR/ArithOps.td
index 993f36f556e87..9d2b8f3a26238 100644
--- a/mlir/include/mlir/Dialect/Arith/IR/ArithOps.td
+++ b/mlir/include/mlir/Dialect/Arith/IR/ArithOps.td
@@ -1688,8 +1688,7 @@ def SelectOp : Arith_Op<"select", [Pure,
     AllTypesMatch<["true_value", "false_value", "result"]>,
     BooleanConditionOrMatchingShape<"condition", "result">,
     DeclareOpInterfaceMethods<InferIntRangeInterface, ["inferResultRangesFromOptional"]>,
-    DeclareOpInterfaceMethods<SelectLikeOpInterface>,
-  ] # ElementwiseMappable.traits> {
+    DeclareOpInterfaceMethods<SelectLikeOpInterface>]> {
   let summary = "select operation";
   let description = [{
     The `arith.select` operation chooses one value based on a binary condition

``````````

</details>


https://github.com/llvm/llvm-project/pull/145007


More information about the Mlir-commits mailing list