[Mlir-commits] [mlir] [MLIR] Print more user-friendly error message when generating local reproducer and threading is enabled (PR #144905)

[Amir Bishara]

================
@@ -0,0 +1,9 @@
+// Test that attempting to create a local crash reproducer without disabling threading
+// prints an error from the pass manager (as opposed to crashing with a stack trace).
+
+// We need to use `||` in the RUN command because lit will fail the test due to mlir-opt
+// returning non-zero status for this test case, however this is the intended behaviour.
+
+// RUN: mlir-opt --mlir-pass-pipeline-local-reproducer --mlir-pass-pipeline-crash-reproducer=%t %s 2>&1 || FileCheck --input-file %s %s
----------------
amirBish wrote:

Please use `--verify-diagnostics`  in the run command, and make sure to catch the error with `expected-error at +1` . (see invalid lit tests in general).

https://github.com/llvm/llvm-project/pull/144905