[Mlir-commits] [mlir] [mlir] Return vectorized values instead of replacing (PR #144158)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Thanks for the updates - this is roughly what I expected 🙂

I’ve posted a few general discussion points, but they’re non-blocking. The main issue I'd like to flag is naming (`VectorizationHookResult` vs. `VectorizationResult`) - but naming is hard 🙂

By the way, @Max191 - I noticed you force-pushed and rewrote the history. Please try to avoid that, and keep in mind:
* https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes

>From experience, many of us do rebase and force-push, but without squashing (i.e., we preserve individual commits). I'm personally fine with that, as long as the original commits are retained - otherwise it becomes harder to follow the review context, especially for post-commit review.

Not a big deal, just a kind request for future PRs 🙂
And as for rebasing strategies in general - that's a topic better suited for Discourse.

https://github.com/llvm/llvm-project/pull/144158