[Mlir-commits] [mlir] [mlir][spirv]: Add Image to Vulkan Storage Class Map (PR #144899)

[Jack Frankland]

FranklandJack wrote:

> Can we test this?

So I did have a look at the lit tests for this pass. Seems we only test the storage classes that map from memory spaces that are common to the OpenCL and Vulkan environments. The way the lit test is defined at the moment means it needs to be run in both OpenCL and Vulkan modes which I think is going to cause the CL path to fail since the index `12` won't map to anything: https://github.com/llvm/llvm-project/blob/main/mlir/test/Conversion/MemRefToSPIRV/map-storage-class.mlir#L1

https://github.com/llvm/llvm-project/pull/144899