[Mlir-commits] [mlir] [MLIR] Determine contiguousness of memrefs with dynamic dimensions (PR #142421)

[Momchil Velikov]

================

----------------
momchil-velikov wrote:

> * `maxContigDim` tests `getNumContiguousTrailingDims`, `contigTrailingDim` tests `areTrailingDimsContiguous`, and `identityMaps` tests both - is there an intended pattern here?

I have either replied or did not understand the question. 

> * The actual "complex" logic seems to reside in `getNumContiguousTrailingDims`. Would it make sense to focus the tests more narrowly on that hook?

I've reworked the test cases to be more "focused".

> * Could the test names (`maxContigDim`,` contigTrailingDim`, `identityMaps`) be made more descriptive? Alternatively, adding comments explaining what each test is validating would help - it’s not immediately clear to me.

Added comments what  each test is validating. Also put comments to each individual test case.

> * I’d suggest renaming `identityMaps` to something like `noStrides` or `defaultStrides`, since the other tests explicitly include strides. The natural split seems to be "with strides" vs "without strides".

Test removed and a test case moved.


https://github.com/llvm/llvm-project/pull/142421