[Mlir-commits] [mlir] [mlir][arith] Fix multiplication canonicalizations (PR #144787)

[Jakub Kuderski]

https://github.com/kuhar commented:

Thanks for fixing this. I think we should drop these canon patterns all together -- the issue is that one of the results is always unused so it's probably too aggressive to be enabled by default without a clear benefit. Similarly, it doesn't allow us to decompose muli_extended to plain muli without being folded back again.

I'm not aware of any code that relies on these patterns anymore.

https://github.com/llvm/llvm-project/pull/144787