[Mlir-commits] [mlir] Lower allreduce (PR #144716)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- mlir/include/mlir/Dialect/MPI/IR/MPI.h mlir/include/mlir/Dialect/Mesh/IR/MeshOps.h mlir/include/mlir/Dialect/Mesh/Transforms/Simplifications.h mlir/include/mlir/Dialect/Mesh/Transforms/Transforms.h mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp mlir/lib/Conversion/MeshToMPI/MeshToMPI.cpp mlir/lib/Dialect/MPI/IR/MPIOps.cpp mlir/lib/Dialect/Mesh/IR/MeshOps.cpp mlir/lib/Dialect/Mesh/Transforms/Transforms.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Conversion/MeshToMPI/MeshToMPI.cpp b/mlir/lib/Conversion/MeshToMPI/MeshToMPI.cpp
index a5dd2ab72..c248be401 100644
--- a/mlir/lib/Conversion/MeshToMPI/MeshToMPI.cpp
+++ b/mlir/lib/Conversion/MeshToMPI/MeshToMPI.cpp
@@ -523,19 +523,26 @@ static mpi::MPI_ReductionOpEnumAttr getMPIReductionOp(ReductionKindAttr kind) {
   auto ctx = kind.getContext();
   switch (kind.getValue()) {
   case ReductionKind::Sum:
-    return mpi::MPI_ReductionOpEnumAttr::get(ctx, mpi::MPI_ReductionOpEnum::MPI_SUM);
+    return mpi::MPI_ReductionOpEnumAttr::get(ctx,
+                                             mpi::MPI_ReductionOpEnum::MPI_SUM);
   case ReductionKind::Product:
-    return mpi::MPI_ReductionOpEnumAttr::get(ctx, mpi::MPI_ReductionOpEnum::MPI_PROD);
+    return mpi::MPI_ReductionOpEnumAttr::get(
+        ctx, mpi::MPI_ReductionOpEnum::MPI_PROD);
   case ReductionKind::Min:
-    return mpi::MPI_ReductionOpEnumAttr::get(ctx, mpi::MPI_ReductionOpEnum::MPI_MIN);
+    return mpi::MPI_ReductionOpEnumAttr::get(ctx,
+                                             mpi::MPI_ReductionOpEnum::MPI_MIN);
   case ReductionKind::Max:
-    return mpi::MPI_ReductionOpEnumAttr::get(ctx, mpi::MPI_ReductionOpEnum::MPI_MAX);
+    return mpi::MPI_ReductionOpEnumAttr::get(ctx,
+                                             mpi::MPI_ReductionOpEnum::MPI_MAX);
   case ReductionKind::BitwiseAnd:
-    return mpi::MPI_ReductionOpEnumAttr::get(ctx, mpi::MPI_ReductionOpEnum::MPI_BAND);
+    return mpi::MPI_ReductionOpEnumAttr::get(
+        ctx, mpi::MPI_ReductionOpEnum::MPI_BAND);
   case ReductionKind::BitwiseOr:
-    return mpi::MPI_ReductionOpEnumAttr::get(ctx, mpi::MPI_ReductionOpEnum::MPI_BOR);
+    return mpi::MPI_ReductionOpEnumAttr::get(ctx,
+                                             mpi::MPI_ReductionOpEnum::MPI_BOR);
   case ReductionKind::BitwiseXor:
-    return mpi::MPI_ReductionOpEnumAttr::get(ctx, mpi::MPI_ReductionOpEnum::MPI_BXOR);
+    return mpi::MPI_ReductionOpEnumAttr::get(
+        ctx, mpi::MPI_ReductionOpEnum::MPI_BXOR);
   default:
     assert(false && "Unknown/unsupported reduction kind");
   }
@@ -908,7 +915,8 @@ struct ConvertMeshToMPIPass
 
     // No mesh dialect should left after conversion...
     target.addIllegalDialect<mesh::MeshDialect>();
-    // ...except the global MeshOp. MeshShapeOp which will get folded separately.
+    // ...except the global MeshOp. MeshShapeOp which will get folded
+    // separately.
     target.addLegalOp<mesh::MeshOp, mesh::MeshShapeOp>();
     // Allow all the stuff that our patterns will convert to
     target.addLegalDialect<

``````````

</details>


https://github.com/llvm/llvm-project/pull/144716