[Mlir-commits] [mlir] [mlir][spirv] Add support for SPV_ARM_tensors (PR #144667)
Igor Wodiany
llvmlistbot at llvm.org
Wed Jun 18 06:46:32 PDT 2025
https://github.com/IgWod-IMG commented:
Thanks for contributing this. I added few comments.
I pointed it out few times, but I believe you don't need `llvm::` with casts, etc. It's an artifact of refactoring that was done in the past: https://github.com/llvm/llvm-project/pull/141458#discussion_r2128984821
Also, we probably should add a test in here: https://github.com/llvm/llvm-project/blob/main/mlir/test/Dialect/SPIRV/IR/availability.mlir
https://github.com/llvm/llvm-project/pull/144667
More information about the Mlir-commits
mailing list