[Mlir-commits] [mlir] [MLIR] Determine contiguousness of memrefs with dynamic dimensions (PR #142421)

[Andrzej Warzyński]

banach-space wrote:

> Just a drive-by comment - when I started contributing here, a reviewer kindly pointed out to me in this [#135096 (comment)](https://github.com/llvm/llvm-project/pull/135096#issuecomment-2797902624) that force pushing isn't recommended https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes

+1 

That said, that document also states:
> Sometimes, a rebase might be needed to update your branch with a fix for a test or in some dependent code.

I do occasionally rebase to keep my branch up-to-date with main, especially for longer-lived PRs that are still under review. I'm always happy to adapt that habit, of course!

For me, the real concern is around “rebase + squash”, since that can wipe out intermediate commits that were already reviewed or discussed - and that history can be valuable.

Just posting this as a side note to clarify my current workflow - again, very open to adjusting it if needed.

https://github.com/llvm/llvm-project/pull/142421