https://github.com/kuhar requested changes to this pull request. This also needs llvm/spirv lowering changes and lit tests. We don't need unit tests. See https://mlir.llvm.org/getting_started/TestingGuide/#test-categories https://github.com/llvm/llvm-project/pull/144344