[Mlir-commits] [mlir] [mlir][spirv] Add definition for GL Length (PR #144041)

[Igor Wodiany]

IgWod-IMG wrote:

The comment in the header file: https://github.com/llvm/llvm-project/blob/404597061f974470e8bd1198e44d024fac8319a1/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVGLCanonicalization.h#L28 implies to me that GLSL canonicalization is separate because of the availability reasons, or at least that's my interpretation. In this case that wouldn't be an issue.

Having said that, I agree it does make sense to put it with other GL ops -- it is only useful if GL ops are available anyway and it will make the code cleaner. I'll update this PR.

https://github.com/llvm/llvm-project/pull/144041