[Mlir-commits] [mlir] [mlir][emitc] Inline constant when translate (PR #143485)

[Marius Brehler]

marbre wrote:

> > I've thought about side effects in the past and I don't know if we want to simply mark the ops as pure as you might target overloaded C++ classes that do whatever. But especially on the call_opaque op I want to be able to mark an instance as pure with an attribute for example and then override getMemoryEffects accordingly.
> 
> Wouldn't the constant op be able to check for that with the new interface proposed here #142771 ? We can check if the type is scalar and then e.g. say that it doesn't have side effects.

That could be indeed an interesting solution but I haven't looked to close to the new interface and don't know if it allows to do so.

https://github.com/llvm/llvm-project/pull/143485