[Mlir-commits] [mlir] [mlir][emitc] Inline constant when translate (PR #143485)

[Kirill Chibisov]

kchibisov wrote:

>We could however make emitc.expression IsolatedFromAbove, which IINM would prevent CSE from simplifying it out of the expression. This would both allow form-expressions to run at any point in the pipeline and allow lowering passes to generate expressions safely if desired. WDYT?

Isn't `IsolatedFromAbove` prevents all uses of above operations, so even if they are in args it won't work, so the whole use of `emitc.expression` would be pointless since it won't be able to refer any data, where the point is to refer data and apply `CExpression` operations to it to yield a result?

https://github.com/llvm/llvm-project/pull/143485