[Mlir-commits] [mlir] [mlir][linalg] Update pack and unpack documentation (PR #143903)

[Andrzej Warzyński]

================
@@ -1824,6 +1824,17 @@ func.func @unpack_invalid_outer_dims_perm(%source: tensor<128x256xf32>, %dest: t
 
 // -----
 
+// Here we have the source tensor being tiled as: `source[1] / 32` and `source[0] / 16` but the inner_dims_pos does not imply
+// a transpose of the outer dimensions for the result tensor. The tiled dimensions appear in the result tensor in the order
+// they appear in the source tensor, i.e. 16x4x32x16
----------------
banach-space wrote:

Hm, isn't this example simply missing ` outer_dims_perm = [1, 0]`? So yes, the order of the outer dims should not be permuted.

https://github.com/llvm/llvm-project/pull/143903