[mlir] [mlir][Vector] Tighten up application conditions in TransferReadAfter… (PR #143869)

[Andrzej Warzyński]

================
@@ -1540,6 +1540,43 @@ func.func @store_to_load_tensor_broadcast(%arg0 : tensor<4x4xf32>,
 
 // -----
 
+// CHECK-LABEL: func @store_to_load_tensor_no_actual_broadcast
+//   CHECK-NOT:   vector.broadcast
+//   CHECK-NOT:   vector.transpose
+//       CHECK:   vector.transfer_write
+//       CHECK:   vector.transfer_read
+func.func @store_to_load_tensor_no_actual_broadcast(%arg0 : tensor<?x?xf32>,
----------------
banach-space wrote:

[nit] Would you object to using a prefix like `@negative_` to capture that this a negative case? Mostly so that we flag "negative" cases consistently (some relatively new guidelines here: https://mlir.llvm.org/getting_started/TestingGuide/#step-3-add-the-newly-identified-missing-case)

https://github.com/llvm/llvm-project/pull/143869