[Mlir-commits] [mlir] [mlir][Vector] Tighten up application conditions in TransferReadAfter… (PR #143869)

[Kunwar Grover]

================
@@ -4684,15 +4687,27 @@ struct TransferReadAfterWriteToBroadcast
     if (getUnusedDimsBitVector({readOp.getPermutationMap()}) !=
         getUnusedDimsBitVector({defWrite.getPermutationMap()}))
       return failure();
-    if (readOp.getIndices() != defWrite.getIndices() ||
-        readOp.getMask() != defWrite.getMask())
+    // This pattern should only catch the broadcast case, the non-broadcast case
+    // should be done separately to keep application conditions clean and
+    // separate.
----------------
Groverkss wrote:

What if we had a transpose but no broadcast? The no broadcast no transpose case is handled by the folder, but previously, this pattern was also handeling no broadcast but transpose permutation map. Are we removing that case?

https://github.com/llvm/llvm-project/pull/143869