[Mlir-commits] [mlir] [mlir][vector] Add unroll patterns for vector.load and vector.store (PR #143420)

[Andrzej Warzyński]

================
@@ -54,6 +54,33 @@ static SmallVector<Value> sliceTransferIndices(ArrayRef<int64_t> elementOffsets,
   return slicedIndices;
 }
 
+// Compute the new indices for vector.load/store by adding `offsets` to
+// `originalIndices`.
----------------
banach-space wrote:

Note, this method is unrelated to `vector.load`/`vector.store`. It merely takes to array refs and sums them. It just happens to be used by an unroll pattern for `vector.load` + `vector.store`. It also doesn't really care what the inputs are (as `originalIndices` imply). 

In general, if this is meant only for `vector.load` + `vector.store`, then you might be able to replace it with inline code if you follow my suggestion below to use e.g. `llvm::zip`.

https://github.com/llvm/llvm-project/pull/143420