[Mlir-commits] [mlir] [mlir][spirv][nfc] Add missing tests for GL Tanh Op (PR #143538)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-spirv

Author: Igor Wodiany (IgWod-IMG)

<details>
<summary>Changes</summary>

The problem was noticed when adding Log2 operation.

---
Full diff: https://github.com/llvm/llvm-project/pull/143538.diff


2 Files Affected:

- (modified) mlir/test/Dialect/SPIRV/IR/gl-ops.mlir (+26) 
- (modified) mlir/test/Target/SPIRV/gl-ops.mlir (+2) 


``````````diff
diff --git a/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir b/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir
index f238336f14a4d..50cf1b26d42ab 100644
--- a/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir
+++ b/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir
@@ -763,3 +763,29 @@ func.func @log2_invalid_type(%arg0 : i32) -> () {
   %0 = spirv.GL.Log2 %arg0 : i32
   return
 }
+
+// -----
+
+//===----------------------------------------------------------------------===//
+// spirv.GL.Tanh
+//===----------------------------------------------------------------------===//
+
+func.func @tanh(%arg0 : f32) -> () {
+  // CHECK: spirv.GL.Tanh {{%.*}} : f32
+  %0 = spirv.GL.Tanh %arg0 : f32
+  return
+}
+
+func.func @tanhvec(%arg0 : vector<3xf16>) -> () {
+  // CHECK: spirv.GL.Tanh {{%.*}} : vector<3xf16>
+  %0 = spirv.GL.Tanh %arg0 : vector<3xf16>
+  return
+}
+
+// -----
+
+func.func @tanh_invalid_type(%arg0 : i32) -> () {
+  // expected-error @+1 {{op operand #0 must be 16/32-bit float or vector of 16/32-bit float values}}
+  %0 = spirv.GL.Tanh %arg0 : i32
+  return
+}
diff --git a/mlir/test/Target/SPIRV/gl-ops.mlir b/mlir/test/Target/SPIRV/gl-ops.mlir
index 64592a4d5079b..368f60e102dc1 100644
--- a/mlir/test/Target/SPIRV/gl-ops.mlir
+++ b/mlir/test/Target/SPIRV/gl-ops.mlir
@@ -42,6 +42,8 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> {
     %19 = spirv.GL.Atanh %arg0 : f32
     // CHECK: {{%.*}} = spirv.GL.Log2 {{%.*}} : f32
     %20 = spirv.GL.Log2 %arg0 : f32
+    // CHECK: {{%.*}} = spirv.GL.Tanh {{%.*}} : f32
+    %21 = spirv.GL.Tanh %arg0 : f32
     spirv.Return
   }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/143538