[Mlir-commits] [mlir] [mlir][Vector] Support `xfer_read(vector.extract))` folding with dynamic indices (PR #143269)
James Newling
llvmlistbot at llvm.org
Mon Jun 9 09:56:40 PDT 2025
================
@@ -148,3 +148,33 @@ func.func @subvector_extract(%m: memref<?x?xf32>, %idx: index) -> vector<16xf32>
return %1 : vector<16xf32>
}
+// -----
+
+// CHECK: #[[$MAP:.*]] = affine_map<()[s0, s1] -> (s0 + s1)>
+// CHECK-LABEL: func @transfer_read_1d_extract_dynamic(
+// CHECK-SAME: %[[MEMREF:.*]]: memref<?xf32>, %[[M_IDX:.*]]: index, %[[E_IDX:.*]]: index
+// CHECK: %[[APPLY:.*]] = affine.apply #[[$MAP]]()[%[[M_IDX]], %[[E_IDX]]]
+// CHECK: %[[RES:.*]] = memref.load %[[MEMREF]][%[[APPLY]]]
+func.func @transfer_read_1d_extract_dynamic(%m: memref<?xf32>, %idx: index,
+ %offset: index) -> f32 {
+ %cst = arith.constant 0.0 : f32
+ %vec = vector.transfer_read %m[%idx], %cst {in_bounds = [true]} : memref<?xf32>, vector<5xf32>
+ %elem = vector.extract %vec[%offset] : f32 from vector<5xf32>
+ return %elem : f32
+}
+
+// -----
+
+// CHECK: #[[$MAP:.*]] = affine_map<()[s0, s1] -> (s0 + s1)>
+// CHECK-LABEL: func @transfer_read_2d_extract_dynamic(
+// CHECK-SAME: %[[MEMREF:.*]]: memref<?x?xf32>, %[[M_IDX:.*]]: index, %[[ROW:.*]]: index, %[[COL:.*]]: index
+// CHECK: %[[ROW_APPLY:.*]] = affine.apply #[[$MAP]]()[%[[M_IDX]], %[[ROW]]]
+// CHECK: %[[COL_APPLY:.*]] = affine.apply #[[$MAP]]()[%[[M_IDX]], %[[COL]]]
+// CHECK: %[[RES:.*]] = memref.load %[[MEMREF]][%[[ROW_APPLY]], %[[COL_APPLY]]]
+func.func @transfer_read_2d_extract_dynamic(%m: memref<?x?xf32>, %idx: index,
----------------
newling wrote:
nit: use `%row_idx` and `%col_idx` instead of using the same %idx` for both indices, to ensure algorithm is iterating through indices as expected.
https://github.com/llvm/llvm-project/pull/143269
More information about the Mlir-commits
mailing list