[Mlir-commits] [mlir] [mlir][gpu][spirv] Remove rotation semantics of gpu.shuffle up/down (PR #139105)

[Jakub Kuderski]

================
@@ -435,26 +435,59 @@ LogicalResult GPUShuffleConversion::matchAndRewrite(
     return rewriter.notifyMatchFailure(
         shuffleOp, "shuffle width and target subgroup size mismatch");
 
+  // Ensure the offset is a signless/unsigned integer.
+  if (adaptor.getOffset().getType().isSignedInteger())
+    return rewriter.notifyMatchFailure(
+        shuffleOp, "shuffle offset must be a signless/unsigned integer");
----------------
kuhar wrote:

If this is disallowed by the verifier, we would be better of using an assertion here to know when the verification code no longer enforces this

https://github.com/llvm/llvm-project/pull/139105