[Mlir-commits] [mlir] [mlir][tensor] remove tensor.insert constant folding out of canonicalization (PR #142671)

[Mehdi Amini]

================
@@ -176,6 +176,9 @@ void populateFoldConstantExtractSlicePatterns(
           return false;
         });
 
+/// Patterns to fold inserts into a constant into a new constant.
+void populateFoldInsertAfterConstant(RewritePatternSet &patterns);
----------------
joker-eph wrote:

It's probably safer to remove the pattern for now, and maybe think about introducing a "tensor-constant-folding" pass separately. I suspect such pass would want options about a maximum size for folding a constant or other option for the strategy to adopt.

https://github.com/llvm/llvm-project/pull/142671