[Mlir-commits] [mlir] [mlir][tensor] remove tensor.insert constant folding out of canonicalization (PR #142671)

[llvmlistbot at llvm.org]

https://github.com/MaheshRavishankar requested changes to this pull request.

Sorry to add to the trouble here. While I am all for removing things from canonicalizations, this is a regression in functionality, and downstream users who might be implicitly relying on this (cause it is a canonicalization and it kicks in whether you ask for it or not) do not have a way to recover than copying it into their downstream projects. 

If we havent decided on a place to put these patterns (maybe a place where all the constant folding patterns get added), we should probably just leave things as is.

https://github.com/llvm/llvm-project/pull/142671