[Mlir-commits] [mlir] [mlir][spirv] Truncate Literal String size at max number words (PR #142916)

[Davide Grohmann]

davidegrohmann wrote:

> Thank you for your contribution!
> 
> If possible, could you please try to add a test to exercise this change? I believe a target test should do the trick (see `mlir/test/Target/SPIRV`). Those tests serialize given MLIR into SPIR-V and then deserialize the SPIR-V back to MLIR. So, I would hope you could see a truncation after the roundtrip.

It has been tricky to add a good test for this. Something needs to trigger the encoding of a string literal with more than 262140 chars.
Any suggestion on which spirv operation to use in such a test?

https://github.com/llvm/llvm-project/pull/142916